-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extending Media attribute subscriptions to iOS tv-casting-app/framework #22964
Merged
woody-apple
merged 1 commit into
project-chip:master
from
sharadb-amazon:ios-subs-20220926
Oct 4, 2022
Merged
Extending Media attribute subscriptions to iOS tv-casting-app/framework #22964
woody-apple
merged 1 commit into
project-chip:master
from
sharadb-amazon:ios-subs-20220926
Oct 4, 2022
+2,035
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost and
kpschoedel
September 29, 2022 21:57
pullapprove
bot
requested review from
lazarkov,
LuDuda,
msandstedt,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
September 29, 2022 21:57
chrisdecenzo
approved these changes
Sep 29, 2022
PR #22964: Size comparison from 852c879 to 1390b8b Increases (4 builds for cc13x2_26x2, esp32)
Decreases (5 builds for cc13x2_26x2, psoc6, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
sharadb-amazon
force-pushed
the
ios-subs-20220926
branch
from
September 30, 2022 00:12
1390b8b
to
e3ba925
Compare
PR #22964: Size comparison from a334714 to e3ba925 Increases (4 builds for bl602, cc13x2_26x2, esp32, psoc6)
Decreases (6 builds for bl602, bl702, cc13x2_26x2, esp32, nrfconnect, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Oct 4, 2022
sharadb-amazon
added a commit
to sharadb-amazon/connectedhomeip
that referenced
this pull request
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
The iOS TV Casting app and MatterTvCastingBridge.framework do not support subscribing to attributes on a Matter TV.
Fixes #20065
Change overview
Testing
Tested by running the iOS tv-casting-app against the tv-app. Checked that the subscription was established successfully and Read response received.
| | |